Repository navigation
Conversation
Contributor
SougandhS
force-pushed
the
PreviewVal
branch
4 times, most recently
from
November 9, 2026 09:02
c492818 to
cc327f1
Compare
This commit adds a "Preview" button on the String Substitution pref page. It is enabled for a single selection and opens a small dialog showing the variable's name, value, description and contributing plug-in, each with a bold title. This will be useful for readability when there is long values
There was a problem hiding this comment.
🟢 Approval recommended
The String Substitution preview change has no active review issues.
No open issues 🎉
What changed in this PR
Adds a Preview action to the String Substitution preference page, making lengthy variable values easier to read without editing them.
Changes:
- Enables Preview when exactly one variable is selected.
- Adds a resizable, read-only dialog with bold headings for variable details and contributing plug-in information.
- Adds localized labels and simplifies existing iterator loops.
| File | Description |
|---|---|
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreviewDialog.java |
Implements the formatted variable preview dialog. |
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/StringVariablePreferencePage.java |
Adds Preview button handling and simplifies loops. |
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.properties |
Defines localized preview labels. |
debug/org.eclipse.debug.ui/ui/org/eclipse/debug/internal/ui/preferences/DebugPreferencesMessages.java |
Declares the corresponding message fields. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a "Preview" button on the String Substitution pref page. It is enabled for a single selection and opens a small dialog showing the variable's name, value, description and contributing plug-in, each with a bold title. This will be useful for readability when there are lengthy values